fix: include quote slippage value in MixPanel event properties - #9786
Open
micaelae wants to merge 5 commits into
Open
fix: include quote slippage value in MixPanel event properties#9786micaelae wants to merge 5 commits into
micaelae wants to merge 5 commits into
Conversation
micaelae
marked this pull request as ready for review
August 4, 2026 23:44
micaelae
enabled auto-merge
August 4, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Saves the
QuoteResponse["quote"]["slippage"]value in the txHistory to populate the Submitted, Failed and Completed MixPanel eventsReferences
Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-4446
Checklist
Note
Low Risk
Single-field analytics fix on history creation with a safe
?? 0fallback; no submission or transaction logic changes.Overview
Bridge transaction history no longer hardcodes slippage to
0when a quote is submitted. On theAddHistoryItemsubmit step,slippagePercentageis set fromquoteResponse.quote.slippage, falling back to0when missing.That value is persisted on the history item so post-submission Unified SwapBridge MixPanel events (Submitted, Failed, Completed) can report the actual slippage limit instead of always sending zero.
Tests and snapshots were updated to expect
slippage: 0.01on the mock quote and matchingslippagePercentageon the stored history item.Reviewed by Cursor Bugbot for commit 75280ce. Bugbot is set up for automated code reviews on this repo. Configure here.